Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092 ) Change subject: bsc: test lchan rel during LCS Loc Req ...................................................................... Patch Set 2: Code-Review-1 (5 comments) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092/comment/aafa4cc4_c934… PS2, Line 11679: TC_emerg_call_and_lcs_loc_req Why are you removing this one? Looks like unintentionally... https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092/comment/305b1893_255f… PS2, Line 10304: altstep no_bssmap_clear_req() runs on MSC_ConnHdlr { 'private', unless you want to use this from other modules. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092/comment/5c618400_6d68… PS2, Line 10311: type enumerated RslRel { 'private', unless you want to use this from other modules. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092/comment/d29498f4_864f… PS2, Line 10318: 'b7'O Can we use f_rnd_ra_emerg() here? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092/comment/dd388beb_40ad… PS2, Line 10328: isbound Are you sure it should be isbound() and not ischosen()? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28092 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idea690a4aa4aecbe4642a16e96d086cc0538564a Gerrit-Change-Number: 28092 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 May 2022 23:23:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment