Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347?usp=email ) Change subject: pfcp up_function_features: allow shorter lengths ...................................................................... Patch Set 1: (2 comments) File src/libosmo-pfcp/pfcp_ies_custom.c: https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347/comment/4a51ea7b_82dec78e PS1, Line 435: * if the peer sends less octets, make do with what we get. */ "make do" ? https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347/comment/b3b96f18_0d923e71 PS1, Line 436: memset(up_function_features->bits, 0, sizeof(up_function_features->bits)); we can probably avoid memcpying twice. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I40e255fd0b4770e578aea7a10ba88f5eeba087f4 Gerrit-Change-Number: 36347 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Mar 2024 11:40:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment