Attention is currently required from: char.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/36376?usp=email )
Change subject: add missing modules to setup.py
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Calling each binary with --help during build and
checking if it crashes is a fairly simple "smoke test" I've seen done
before. That would have caught the issue fixed by this patch, at least.
Sounds like a good idea to me! I was about to mention some important details on how to
implement this correctly (e.g. that we actually need to install pySim as a package) in
`contrib/jenkins.sh`, but ended up writing a patch myself while exploring possible options
;)
https://gerrit.osmocom.org/c/pysim/+/36383 contrib/jenkins.sh: add 'distcheck' job
to check package integrity
https://gerrit.osmocom.org/c/osmo-ci/+/36384 gerrit-verifications: execute
'distcheck' job for pysim
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/36376?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I330d5e35e5f1b508c6209b6894009b5fdd35d660
Gerrit-Change-Number: 36376
Gerrit-PatchSet: 2
Gerrit-Owner: char <osmocom(a)hypodyne.net>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: char <osmocom(a)hypodyne.net>
Gerrit-Comment-Date: Thu, 21 Mar 2024 18:23:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: char <osmocom(a)hypodyne.net>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment