[S] Change in osmo-bsc[master]: pcuif_proto: signal BTS model via PCUIF - gerrit-log

5 Oct 2023


      Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34649?usp=email )
Change subject: pcuif_proto: signal BTS model via PCUIF
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
File include/osmocom/bsc/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/34649/comment/1cc8006c_bae5c03a 
PS2, Line 69: /* BTS model */
same comments as osmo-pcu patch.
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34649/comment/1cbcc097_bd5ac068 
PS2, Line 310: 		info_ind->bts_model = PCU_IF_BTS_MODEL_UNSPEC;
why aren't other values added?
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34649?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4b58912ad7be3070829614853901aa19108ba2c0
Gerrit-Change-Number: 34649
Gerrit-PatchSet: 2
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 05 Oct 2023 11:42:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment