Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27470 )

Change subject: bsc_nat_sccp_inst: local_sccp_addr -> addr ......................................................................

Patch Set 2:

(1 comment)

File include/osmocom/bsc_nat/bsc_nat.h:

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27470/comment/bbee2312_1d1a38a2 PS1, Line 28: struct osmo_sccp_addr addr; /* OsmoBSCNAT's local address */

Maybe loc_addr or local_addr would be more intuitive when reading code.

I've used addr in other places too in later patches in this patchset, IMHO it is nicely consistent and short:

sccp_inst->addr subscr_conn->bsc->addr subscr_conn->msc->addr

Since there is no other address for the sccp_inst it should be clear that it's the local address. Also there's the comment in case it's not clear.