neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libasn1c/+/37989?usp=email )

Change subject: coverity: CID#27206 ......................................................................

coverity: CID#27206

prevent negative bitshift.

Change-Id: Ic6068277add1e336c67409d48211d45493153924 --- M src/per_support.c 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/89/37989/1

diff --git a/src/per_support.c b/src/per_support.c index a1c5ae7..7e55263 100644 --- a/src/per_support.c +++ b/src/per_support.c @@ -490,6 +490,9 @@ buf[2] = bits >> 8, buf[3] = bits; else { + /* sanity: prevent negative bitshift (CID#27206) */ + if (obits < 24) + return -1; per_put_few_bits(po, bits >> (obits - 24), 24); per_put_few_bits(po, bits, obits - 24); }