Attention is currently required from: jolly, laforge, pespin.

dexter has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email )

Change subject: ta_control: Fix skip_block_num not reset when switching TS to PDCH ......................................................................

Patch Set 2: Code-Review+1

(3 comments)

Patchset:

PS2: I have looked through the code, it does what the commit message says.

File include/osmo-bts/ta_control.h:

https://gerrit.osmocom.org/c/osmo-bts/+/41790/comment/1d3b0fc3_82c0e4d6?usp=... : PS2, Line 6: maybe remove the line break?

File src/common/ta_control.c:

https://gerrit.osmocom.org/c/osmo-bts/+/41790/comment/7d3451b5_d3037c8d?usp=... : PS2, Line 47: /* Trigger loop on first TA input: */ Maybe put this comment above the function? (I guess both assignments are required for the trigger)