Attention is currently required from: laforge. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email ) Change subject: bibliography.adoc: add TW-TS-* references ...................................................................... Patch Set 1: (1 comment) File common/chapters/bibliography.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289/comment/534d7bbd_fe93… : PS1, Line 240: - [[[tw-ts-005]]] TW-TS-005: Hexadecimal file format for sequences of RTP : payloads for GSM speech codecs : https://www.freecalypso.org/specs/tw-ts-005-v010003.txt Right now there are two unit tests in libosmocore (for `osmo_fr_sid_classify()` and `osmo_efr_sid_classify()`) where the input file to the unit test program is in the same hex format which I later codified as TW-TS-005. I also plan to add some unit tests for `osmo_rtp2trau()` followed by `osmo_trau_frame_encode`, using the same hex format for unit test input data. But I agree that unit tests are very internal components that don't constitute any kind of interface, so perhaps TW-TS-005 does not belong in the bibliography as it does not appear in any formal APIs or other accessible interfaces. Please indicate if I should resubmit this bibliography patch with TW-TS-005 omitted. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia34a61b5f834f2c70f81012dcc816dd6014c784f Gerrit-Change-Number: 39289 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 13 Jan 2025 12:03:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>