Attention is currently required from: wbokslag.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-tetra/+/29386 )
Change subject: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC frame
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-tetra/+/29386/comment/2f6f3f28_d1d41a66
PS1, Line 7: Keep timeslot number in range 1-4 instead of 0-3 in parsing of SYNC frame
Would be good to see the motivation for this change in the commit message.
Why is it needed to shift the timeslot number value from 0..3 to 1..4?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-tetra/+/29386
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: Ib0967fdeef3bf37c612124626a74d240aa571a66
Gerrit-Change-Number: 29386
Gerrit-PatchSet: 1
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Comment-Date: Sun, 18 Sep 2022 12:55:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment