tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26844 )
Change subject: icE1usb fw: Disable the yellow led if LOS ......................................................................
icE1usb fw: Disable the yellow led if LOS
There is no remote side alarm if there is no remote-side ...
Signed-off-by: Sylvain Munaut tnt@246tNt.com Change-Id: I78f43eded5ed6ffde9d86726ccee2b776a3f4675 --- M firmware/ice40-riscv/icE1usb/e1.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/44/26844/1
diff --git a/firmware/ice40-riscv/icE1usb/e1.c b/firmware/ice40-riscv/icE1usb/e1.c index f25e7c1..af59f14 100644 --- a/firmware/ice40-riscv/icE1usb/e1.c +++ b/firmware/ice40-riscv/icE1usb/e1.c @@ -448,6 +448,7 @@ e1->errors.flags &= ~(E1_ERR_F_LOS|E1_ERR_F_ALIGN_ERR); } else { e1_platform_led_set(port, E1P_LED_GREEN, E1P_LED_ST_BLINK); + e1_platform_led_set(port, E1P_LED_YELLOW, E1P_LED_ST_OFF); led_color(48, 0, 0); e1->errors.flags |= E1_ERR_F_ALIGN_ERR; /* TODO: completely off if rx tick counter not incrementing */
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26844 )
Change subject: icE1usb fw: Disable the yellow led if LOS ......................................................................
Patch Set 1: Code-Review+2
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26844 )
Change subject: icE1usb fw: Disable the yellow led if LOS ......................................................................
icE1usb fw: Disable the yellow led if LOS
There is no remote side alarm if there is no remote-side ...
Signed-off-by: Sylvain Munaut tnt@246tNt.com Change-Id: I78f43eded5ed6ffde9d86726ccee2b776a3f4675 --- M firmware/ice40-riscv/icE1usb/e1.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
diff --git a/firmware/ice40-riscv/icE1usb/e1.c b/firmware/ice40-riscv/icE1usb/e1.c index f25e7c1..af59f14 100644 --- a/firmware/ice40-riscv/icE1usb/e1.c +++ b/firmware/ice40-riscv/icE1usb/e1.c @@ -448,6 +448,7 @@ e1->errors.flags &= ~(E1_ERR_F_LOS|E1_ERR_F_ALIGN_ERR); } else { e1_platform_led_set(port, E1P_LED_GREEN, E1P_LED_ST_BLINK); + e1_platform_led_set(port, E1P_LED_YELLOW, E1P_LED_ST_OFF); led_color(48, 0, 0); e1->errors.flags |= E1_ERR_F_ALIGN_ERR; /* TODO: completely off if rx tick counter not incrementing */
-
laforge -
tnt