Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685?usp=email )
Change subject: vty: Introduce cmd 'cs7 instance <0-15> asp NAME audit
point-code POINT_CODE'
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685/comment/373c679e_28b43…
:
PS2, Line 10: when response arrive
: in case we run under some sort of misalignment with peer.
I find this part of the statement hard to
read/understand. […]
Done
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685/comment/b702e013_b7883…
:
PS2, Line 110: osmo_ss7_pointcode_print_buf
Why not using `osmo_ss7_pointcode_print()` here? […]
I had tons of problems with these same static buffer APIs called in log macros, so
I'm really happy to be using a _buf() version here.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685/comment/52721b24_ec1a1…
:
PS2, Line 118: audit point-code
Are you planning to add more commands related to
`audit`? […]
Yes, I did so because I envision we may want to add more variants later
on, like looking up / matching by sccp address-book name, or to submit an audit for all
addresses in the sccp address-book.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685/comment/52ac76ea_6b659…
:
PS2, Line 132: vty_out
cosmetic: here and below: missing `%%`
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40685?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I607df3d84562e56d329bea1a730e26c8cdaae591
Gerrit-Change-Number: 40685
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 15 Jul 2025 20:19:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>