Attention is currently required from: osmith, fixeria, pespin.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gbproxy/+/33738 )
Change subject: gbprox_rx_ptp_from_bss: fix dangling pointer
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Patchset:
PS1:
> Maybe it helps to set msgb_bcid() to 0 before
returning from these functions? […]
make distcheck also runs through for me..
Patchset:
PS2:
Interesting that it's only this one occurrence.
File src/gb_proxy.c:
https://gerrit.osmocom.org/c/osmo-gbproxy/+/33738/comment/f98b54d4_990dbe8a
PS2, Line 535: msgb_bcid(msg) = 0;
Better explain this in a comment
--
To view, visit
https://gerrit.osmocom.org/c/osmo-gbproxy/+/33738
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: Ie51e37572993cb5dc24ecf13bc300225f09cb744
Gerrit-Change-Number: 33738
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Jul 2023 09:51:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment