fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38427?usp=email )

Change subject: fixup: diameter: fix unused macro param in ?SERVICE ......................................................................

fixup: diameter: fix unused macro param in ?SERVICE

The Product-Name must be a string (list), not an atom.

Change-Id: I52a59f3eaf9784352ad971961c2e31bf5ff9ba90 Fixes: 1545311 "diameter: fix unused macro param in ?SERVICE" --- M src/osmo_dia2gsup.erl 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/27/38427/1

diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index eab34a3..26376a4 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -96,7 +96,8 @@ %% @callback gen_server init(State) -> % DIAMETER side - diameter:start_service(?SVC_NAME, ?SERVICE(?MODULE)), + ProdName = atom_to_list(?MODULE), + diameter:start_service(?SVC_NAME, ?SERVICE(ProdName)),

Ip = application:get_env(osmo_dia2gsup, diameter_ip, "127.0.0.8"), Port = application:get_env(osmo_dia2gsup, diameter_port, 3868),