arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )
Change subject: gsmtap: Hide implementation of gsmtap_inst
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Alright, will keep that in mind
I grepped
through the repos and only three are using `gsmtap_isnt_fd()`:
osmo-remsim: Doesn't have a TODO-RELEASE file. Are there any similar files to edit?
osmocom-bb: Seems to have fixed its own version of libosmocore, not sure if there's
anything to do here now.
simtrace2: Similar to osmocom-bb.
Currently, I have a patch for only osmo-remsim sitting locally, because I'm not sure
how to proceed.
How do I best go about this?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e365825555609a5
Gerrit-Change-Number: 34720
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Oct 2023 14:47:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment