Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28994 ) Change subject: Add function to guess AF_UNSPEC address ...................................................................... Patch Set 5: (1 comment) File src/sockaddr_str.c: https://gerrit.osmocom.org/c/libosmocore/+/28994/comment/4edd5ff9_dc653890 PS5, Line 207: rc = osmo_sockaddr_str_from_in6_addr(tmp, &src6->sin6_addr, osmo_ntohs(src6->sin6_port)); This function is useless and should be removed imho. How can one guess the type here? osmo_sockaddr_str_from_in6_addr() will just always return 0 and AF_INET6 will be returned with whatever the struct was filled in (or uninitialized). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1c90c56ce832f53b65e0d18d3cea94621c02a69a Gerrit-Change-Number: 28994 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 12 Aug 2022 11:57:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment