Attention is currently required from: fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/37685?usp=email )
Change subject: pySim-shell: Support other ADMx values beyond ADM1 from
'verify_adm'
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I really don't understand why we get this
`pySim-shell.py:842:26: E1136: Value 'pin_names.inverse' is unsubscriptable
(unsubscriptable-object)`
pylint error. The inverse[] approach is the one documented by the bidict user manual.
Also, we're using it successfully in pySim.cat, pySim.sms and pySim.ts_102_221 without
any problems...
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/37685?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icce6903c1e449889f8bc5003ccfe6af767a26d44
Gerrit-Change-Number: 37685
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Aug 2024 13:21:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment