Attention is currently required from: neels.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33489
to look at the new patch set (#3).
Change subject: rua: RUA_Disc_Ind only when CLIENT is connected ......................................................................
rua: RUA_Disc_Ind only when CLIENT is connected
Only dispatch RUA_Disc_Ind to CLIENT when CLIENT is connected.
Reason:
If a test does not care much about conn cleanup, it may cause a situation where the CLIENT has already disconnected when osmo-hnbgw sends a RUA Disconnect. A disconnected CLIENT port will cause the final verdict to become 'error'. Instead, if the CLIENT is already disconnected, just don't bother, and allow tests to still pass.
This will become necessary, because:
So far a RUA Disconnect without any RANAP payload is not detected by the RUA emulation. But patch Ia0b89e9198794d196a88040ee89bdf24f3b08ae0 will fix it, so that *every* RUA Disconnect causes a RUA_Disc_Ind sent to the CLIENT. From then on, we will see a bunch more RUA_Disc_Ind at the end of tests. Some of those happen *after* the client already disconnected, causing tests to error that have been passing for a long time.
Change-Id: Ia1403f39cfdc75139922292a3eace7a69a64a576 --- M library/rua/RUA_Emulation.ttcn 1 file changed, 31 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/33489/3