Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34175 ) Change subject: msc/BSC_Conn…: ass req/compl: check/use CSD codec ...................................................................... Patch Set 1: (1 comment) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34175/comment/99782f2b_2278… PS1, Line 1154: {ts_CodecCSData})) { I had this at first, but changed it to 2 ifs so we do the checks first (more checks in 1641 and 1645), and then assign codec and tla. I find this slightly more elegant but don't have a strong preference. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34175 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7906e6fdb82c27f071aa55f2f73ba4108bfb46db Gerrit-Change-Number: 34175 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Aug 2023 15:20:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment