Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hlr/+/39006?usp=email )
Change subject: gsup_client: Avoid double memset 0 ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Not sure how a struct assignment works internally, but I remember that it's not guaranteed that padd […]
When I mean "all memory" I mean "all meaningful memory not consisting of padding". This doesn't change anyway the fact that memory in fields is set twice.
Why should I use talloc instead? It's common thing that we use talloc_zero and then set the non-zero fields. TBH I don't see why are you setting a -1 here, it makes no sense to me and I plan to merge this in a while since I already got a +1 and a +2.
-
pespin