pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40785?usp=email )
Change subject: library: Comment out debugging for NGAP/5G-NAS ......................................................................
library: Comment out debugging for NGAP/5G-NAS
The current NGAP and 5G auth code is now working fine, so disable debug logging. Keep it commented out so it can be re-enabled at any time if some related topic needs to be debugged (will eventually happen).
Change-Id: I4250766644742f0fd11ca5e24b1a1a581dc81b4b --- M library/NGAP_Emulation.ttcn M library/milenage/milenage.c 2 files changed, 7 insertions(+), 7 deletions(-)
Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved
diff --git a/library/NGAP_Emulation.ttcn b/library/NGAP_Emulation.ttcn index 4cb2f05..9fbaddc 100644 --- a/library/NGAP_Emulation.ttcn +++ b/library/NGAP_Emulation.ttcn @@ -143,7 +143,7 @@ NGapExpectTable[i].amf_id := omit; NGapExpectTable[i].ran_id := omit; NGapExpectTable[i].vc_conn := null; - log("Found Expect[", i, "] for ", msg, " handled at ", ret); + //log("Found Expect[", i, "] for ", msg, " handled at ", ret); return ret; } } @@ -222,18 +222,18 @@ template (omit) RAN_UE_NGAP_ID ran_id) runs on NGAP_Emulation_CT return boolean { var integer i; - log("f_ngap_ids_known(",amf_id,", ",ran_id,")"); + //log("f_ngap_ids_known(",amf_id,", ",ran_id,")"); for (i := 0; i < sizeof(NGapAssociationTable); i := i+1) { - log("tbl[",i,"]: amf=", NGapAssociationTable[i].amf_ue_ngap_id, - ", ran=", NGapAssociationTable[i].ran_ue_ngap_id); + //log("tbl[",i,"]: amf=", NGapAssociationTable[i].amf_ue_ngap_id, + // ", ran=", NGapAssociationTable[i].ran_ue_ngap_id); /* skip empty records */ if (NGapAssociationTable[i].amf_ue_ngap_id == omit and NGapAssociationTable[i].ran_ue_ngap_id == omit) { - log("skipping empty ", i); + //log("skipping empty ", i); continue; } if (NGapAssociationTable[i].amf_ue_ngap_id == omit) { - log("entry ", i, " has no AMF ID yet (ran=", NGapAssociationTable[i].ran_ue_ngap_id); + //log("entry ", i, " has no AMF ID yet (ran=", NGapAssociationTable[i].ran_ue_ngap_id); /* Table doesn't yet know the AMF side ID, let's look-up only * based on the eNB side ID */ if (match(NGapAssociationTable[i].ran_ue_ngap_id, ran_id)) { diff --git a/library/milenage/milenage.c b/library/milenage/milenage.c index d079a3d..f7a6f74 100644 --- a/library/milenage/milenage.c +++ b/library/milenage/milenage.c @@ -90,7 +90,7 @@ return 0; }
-#define DEBUG +//#define DEBUG #ifdef DEBUG void hexdump(const char *text, const uint8_t *data, int len) {