Attention is currently required from: fixeria, laforge, osmith, pespin.

Hello Jenkins Builder, fixeria, laforge, pespin,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-sgsn/+/36845?usp=email

to look at the new patch set (#6).

The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder

Change subject: doc: set state-dir to /var/lib/osmocom/osmo-sgsn ......................................................................

doc: set state-dir to /var/lib/osmocom/osmo-sgsn

Be consistent with osmo-ggsn, and set the state dir to /var/lib/osmocom/osmo-sgsn. Without this patch, it defaults to the current directory, which means in case of running with the systemd service, /var/lib/osmocom.

Copy osmo-sgsn.cfg and osmo-sgsn-accept-all.cfg to the tests dir and do not set the state-dir there. Usually the user that runs the VTY and CTRL tests is not allowed to write to /var/lib/osmocom. (I've also tried generating these on the fly, but that breaks in 'make distcheck', as I would need to write to the source dir or would need to change osmo-python-tests etc. to read the config file from another directory.)

Related: osmo-ggsn I5b51529b4f8bd2462e54f58a1ce2e2d7c76ff46a Depends: osmo-python-tests Ic312d546da1c21f68a80b6a188616ef9bc84f4c6 Change-Id: I309807ff0bc125d4653222b2b4ba69ded3bbff70 --- M doc/examples/osmo-sgsn/osmo-sgsn-accept-all.cfg M doc/examples/osmo-sgsn/osmo-sgsn.cfg M doc/examples/osmo-sgsn/osmo-sgsn_custom-sccp.cfg M osmoappdesc.py M tests/Makefile.am M tests/ctrl_test_runner.py A tests/osmo-sgsn-accept-all.cfg A tests/osmo-sgsn.cfg M tests/vty_test_runner.py 9 files changed, 111 insertions(+), 8 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/45/36845/6