Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30318 )
Change subject: trxcon: trxcon_fsm: permit loop [P]DCH transitions
......................................................................
Patch Set 2:
(1 comment)
File src/host/trxcon/src/trxcon_fsm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30318/comment/a90fe5a9_1ccb3603
PS1, Line 626: | S(TRXCON_ST_PACKET_DATA),
But how can you end up transitioning
TRXCON_ST_PACKET_DATA -> TRXCON_ST_PACKET_DATA in current code? […]
Ah, indeed I
forgot to add handling of TRXCON_EV_DCH_EST_REQ to trxcon_st_packet_data_action(). Thanks
for pointing this out. Please keep in mind that the implementation of
TRXCON_ST_PACKET_DATA is not 100% complete as we don't have the RLC/MAC layer yet.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30318
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I3b402ec84610a5df744d9b06e5f7dab7a9a3ddad
Gerrit-Change-Number: 30318
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Nov 2022 11:14:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment