[M] Change in pysim[master]: global_platform/scp: refactor _wrap_cmd_apdu - gerrit-log

15 Nov 2024


      Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38635?usp=email )
Change subject: global_platform/scp: refactor _wrap_cmd_apdu
......................................................................
Patch Set 2:
(2 comments)
File pySim/global_platform/scp.py:
https://gerrit.osmocom.org/c/pysim/+/38635/comment/2911f128_39abb87c?usp=ema... :
PS1, Line 279: if self.do_cmac:
...
Adding another indention level does not make functions more readable either... […]
Done
https://gerrit.osmocom.org/c/pysim/+/38635/comment/cf9c83f2_c5671f9a?usp=ema... :
PS1, Line 482: if self.do_cmac:
...
Likewise, maybe do an early return? […]
Done
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/38635?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4c5650337779a4bd1f98673650c6c3cb526d518b
Gerrit-Change-Number: 38635
Gerrit-PatchSet: 2
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Fri, 15 Nov 2024 09:37:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de