laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/29183 )
Change subject: rpm spec: use --disable-static ......................................................................
rpm spec: use --disable-static
Follow what we are doing in other Osmocom rpm packaging by not building and packaging static libraries.
Fix for rpmlint errors when building for OpenSUSE: libosmo-gtlv-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/libosmo-gtlv.a libosmo-pfcp-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/libosmo-pfcp.a libosmo-gtlv-devel.x86_64: E: lto-no-text-in-archive (Badness: 10000) /usr/lib64/libosmo-gtlv.a libosmo-pfcp-devel.x86_64: E: lto-no-text-in-archive (Badness: 10000) /usr/lib64/libosmo-pfcp.a
(If we wanted to build with static libraries, we would need to use -ffat-lto-objects to get rid of the second error.)
Related: https://github.com/rpm-software-management/rpmlint/issues/458 Change-Id: I49dd454afd8bd3473bcadbc8cd8724574011f886 --- M contrib/libosmo-pfcp.spec.in 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved
diff --git a/contrib/libosmo-pfcp.spec.in b/contrib/libosmo-pfcp.spec.in index 4ef2607..e47d52c 100644 --- a/contrib/libosmo-pfcp.spec.in +++ b/contrib/libosmo-pfcp.spec.in @@ -72,6 +72,7 @@ echo "%{version}" >.tarball-version autoreconf -fi %configure \ + --disable-static \ --includedir="%_includedir/%name" make %{?_smp_mflags}
@@ -95,7 +96,6 @@ %dir %{_includedir}/%{name}/osmocom %{_includedir}/%{name}/osmocom/gtlv %{_libdir}/libosmo-gtlv.so -%{_libdir}/libosmo-gtlv.a %{_libdir}/pkgconfig/libosmo-gtlv.pc
%files -n libosmo-pfcp0 @@ -106,7 +106,6 @@ %dir %{_includedir}/%{name}/osmocom %{_includedir}/%{name}/osmocom/pfcp %{_libdir}/libosmo-pfcp.so -%{_libdir}/libosmo-pfcp.a %{_libdir}/pkgconfig/libosmo-pfcp.pc
%changelog
-
laforge