Attention is currently required from: dexter, fixeria, laforge, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38290?usp=email )
Change subject: libosmotrau: add CSD RA2 functions
......................................................................
Patch Set 2:
(2 comments)
File include/osmocom/trau/csd_ra2.h:
https://gerrit.osmocom.org/c/libosmo-abis/+/38290/comment/1bf10950_25d9444b?... :
PS1, Line 58:
here he nbytes indicates the number of _output_ bytes.
See the other comment.
https://gerrit.osmocom.org/c/libosmo-abis/+/38290/comment/a63b900b_ead988b7?... :
PS1, Line 66: ubit_t
so here the nbytes indicats the number of _input_ bytes. I find that a bit confusing. […]
The suggested change has been made in the new patch version.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/38290?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7b98b958651b3fc1a814d119d1b8644c91f98676
Gerrit-Change-Number: 38290
Gerrit-PatchSet: 2
Gerrit-Owner: falconia
falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 26 Sep 2024 23:01:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
falconia