Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29996 ) Change subject: Improve MS logging ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/000afa1b_b28b1090 PS1, Line 9: towaht to what File src/gprs_ms.c: https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/267495bd_fdc7dd83 PS1, Line 1030: if (tlli != GSM_RESERVED_TMSI) meaning: the indentation is wrong, should be two tabs, not three in the line below. https://gerrit.osmocom.org/c/osmo-pcu/+/29996/comment/18a9367c_58f06ca1 PS1, Line 1040: return buf; dead code, did you mean to delete everything below this return? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If9b325764c8fd540d60b6419f32223fd7f5a5898 Gerrit-Change-Number: 29996 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Nov 2022 14:50:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment