[S] Change in osmo-bsc[master]: si2quater: check return value of osmo_earfcn_del() - gerrit-log

11 Apr 2023


      Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32251 )
Change subject: si2quater: check return value of osmo_earfcn_del()
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/32251/comment/bd34aa3c_8768fbbe 
PS2, Line 2082: 	if (osmo_earfcn_del(e, arfcn) != 0)
...
IIUC if you arrived here is because you failed adding the earfcn to the list, so why would you want  […]
Not really. We end up here if generating si2quater fails after adding an EARFCN, so we need to remove it. See `si2q_num()` in `src/osmo-bsc/system_information.c`.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32251
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I227dad57737721c40a508f67616d9f5003bb1a3e
Gerrit-Change-Number: 32251
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 11 Apr 2023 08:59:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment