Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32236 ) Change subject: Merge gsm_network into gsm_bts_sm and place gsm_bts under it ...................................................................... Patch Set 4: (5 comments) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/fee8f64d_5be68596 PS4, Line 406: g_bts_sm->num_bts++;

I find this weird that a BTS is added to `&g_bts_sm->bts_list` in `gsm_bts_alloc()`, but `g_bts_sm-> […] Ack

File src/common/bts_sm.c: https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/4b300e48_d802b7d0 PS4, Line 37: talloc_free

talloc does free() all its children anyway, do we really need to do this manually? I prefer doing it this way in order to control the order of stuff being freed.

File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/914ddc11_1d905977 PS4, Line 154: if (!bts) {

`OSMO_UNLIKELY`? Ack

File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/ab0b3e3a_a507e439 PS4, Line 897: struct gsm_bts_sm *bts_sm

Can we remove this argument since `g_bts_sm` is available globally? Yes we could, I'm not sure if it makes sense doing it in this commit or not, I simply changed the minimum required stuff in this file.

https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/0cddd3b8_ec40428b PS4, Line 957: struct gsm_bts_sm *bts_sm

Can we remove this argument since `g_bts_sm` is available globally? Yes we could, I'm not sure if it makes sense doing it in this commit or not, I simply changed the minimum required stuff in this file.

-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ideb0d458ec631008223f861cf8b46d09524a1a21 Gerrit-Change-Number: 32236 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 11 Apr 2023 09:00:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment