Attention is currently required from: fixeria.

View Change

5 comments:

• File src/common/bts.c:

  • Patch Set #4, Line 406: g_bts_sm->num_bts++;

    I find this weird that a BTS is added to `&g_bts_sm->bts_list` in `gsm_bts_alloc()`, but `g_bts_sm-> […]

    Ack

• File src/common/bts_sm.c:

  • Patch Set #4, Line 37: talloc_free

    talloc does free() all its children anyway, do we really need to do this manually?

    I prefer doing it this way in order to control the order of stuff being freed.

• File src/common/oml.c:

  • Patch Set #4, Line 154: if (!bts) {

    `OSMO_UNLIKELY`?

    Ack

• File src/common/pcu_sock.c:

  • Patch Set #4, Line 897: struct gsm_bts_sm *bts_sm

    Can we remove this argument since `g_bts_sm` is available globally?

    Yes we could, I'm not sure if it makes sense doing it in this commit or not, I simply changed the minimum required stuff in this file.

  • Patch Set #4, Line 957: struct gsm_bts_sm *bts_sm

    Can we remove this argument since `g_bts_sm` is available globally?

    Yes we could, I'm not sure if it makes sense doing it in this commit or not, I simply changed the minimum required stuff in this file.

To view, visit change 32236. To unsubscribe, or for help writing mail filters, visit settings.