Change in osmo-bts[master]: osmo-bts-trx: fix scheduling of dummy FACCH/H and FACCH/F - gerrit-log

20 Apr 2022


      Attention is currently required from: laforge, fixeria, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27805 )
Change subject: osmo-bts-trx: fix scheduling of dummy FACCH/H and FACCH/F
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/osmo-bts-trx/sched_lchan_tchf.c:
https://gerrit.osmocom.org/c/osmo-bts/+/27805/comment/bbf3ecc7_cd22b459 
PS1, Line 333: 		chan_state->dl_facch_bursts = 8;
...
Yes, this is intentional: dl_ongoing_facch is only used in tx_tchh_fn(), where you need to skip enco […]
I've been wondering about the same thing. Maybe add a comment that explains this?
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27805
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ief12eb67ad80de3b71f5226858dc2e0c8ae76948
Gerrit-Change-Number: 27805
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 20 Apr 2022 16:13:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment