Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39860?usp=email ) Change subject: saip-tool: add features to add and remove applications profile elements ...................................................................... Patch Set 1: (2 comments) File contrib/saip-tool.py: https://gerrit.osmocom.org/c/pysim/+/39860/comment/4207e90f_5ada36ac?usp=em… : PS1, Line 349: 0] I am not sure here, As far as I know there can be multiple securityDomain PEs in a profile. If this really is the case, we have to add a parameter to identify the security domain. If not, we should be fine. https://gerrit.osmocom.org/c/pysim/+/39860/comment/e9288f2b_b340e7fb?usp=em… : PS1, Line 375: I wonder if it is better to put this in a method in ProfileElementApplication? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I41db96f2f0ccc29c1725a92215ce6b17d87b76ce Gerrit-Change-Number: 39860 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 27 Mar 2025 13:07:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No