Attention is currently required from: laforge, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42165?usp=email )
Change subject: RTP: implement RTP socket abstraction layer ......................................................................
Patch Set 4:
(2 comments)
File src/common/rtp_abstract.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/e15a138a_6e89c8f8?usp=... : PS3, Line 14: #define HAVE_ORTP
I will change it in the next iteration if Osmocom style preference is to use space here.
Done
https://gerrit.osmocom.org/c/osmo-bts/+/42165/comment/47b2bb7a_23730537?usp=... : PS3, Line 169: osmo_twrtp_twjit_rx_ctrl(rs->twrtp, true);
Not needed, but no harm either. […]
I added an extra comment in the code explaining this aspect.