Attention is currently required from: laforge, pespin, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27430 )
Change subject: osmo-bts-trx: rx_tchh_fn(): fix HR SID detection (wrong offset)
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS4:
to summarize: This change is correct (check only the HR codec payloads and not the TOC). […]
Updated the commit message, thanks for your references and explanation! Regarding your proposal to match SID frames in gsm0503_tch_hr_decode(), I am not sure if it's safe to change behavior of this library function. If you think it's worth it, please let me know. For now I submitted: https://gerrit.osmocom.org/c/osmo-bts/+/27520.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/27430
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie5fa776dcb2b2203a97aed56ecbf2450af7d87c1
Gerrit-Change-Number: 27430
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Wed, 16 Mar 2022 10:12:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Gerrit-MessageType: comment