[L] Change in libosmo-sccp[master]: xua + ipa: Add support for I/O in OSMO_IO mode - gerrit-log

6 Mar 2024

Attention is currently required from: daniel, fixeria, pespin.

laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email )

Change subject: xua + ipa: Add support for I/O in OSMO_IO mode
......................................................................

Patch Set 8:

(3 comments)

File src/osmo_ss7_asp.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/e9681e7a_cc2a5ede 
PS8, Line 657: 				osmo_stream_cli_set_segmentation_cb(asp->client,
xua_segmentation_cb);
...
  So can you name any of them which is not TCP? which is
using the exact same header approach used by  […] I'm happy to rename it to
xua_tcp_segemntation_cb, which is more in line with m3ua_tcp_* names in other places.  As
I don't want to clash with @jolly: Please rename it in your next patch update, jolly!

https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/96bdbf4f_7cf1bc9d 
PS8, Line 663: 			osmo_stream_cli_set_read_cb2(asp->client, xua_cli_read_cb);
...
  You probably need to do
"osmo_stream_cli_set_segmentation_cb(asp->client, NULL);" here too?
good catch.  I didn't think of restart/reconfigure.

https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/e6854f99_689a9cc0 
PS8, Line 833: 		}
...
  so how are we now calling osmo_stream_srv_destroy()
once the socket is detected as closed? […] I think all the "msgb_length(msg) ==
0" cases are just an ugly workaround for code that doesn't register a
disconnect_cb.  

So let's do this properly with disconnect_cb, @jolly is working on that AFAICT.

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369
Gerrit-Change-Number: 35070
Gerrit-PatchSet: 8
Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: daniel &lt;dwillmann(a)sysmocom.de&gt;
Gerrit-Comment-Date: Wed, 06 Mar 2024 10:31:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-MessageType: comment