Attention is currently required from: daniel, fixeria, pespin.

View Change

3 comments:

• File src/osmo_ss7_asp.c:

  • Patch Set #8, Line 657: osmo_stream_cli_set_segmentation_cb(asp->client, xua_segmentation_cb);

    So can you name any of them which is not TCP? which is using the exact same header approach used by […]

    I'm happy to rename it to xua_tcp_segemntation_cb, which is more in line with m3ua_tcp_* names in other places. As I don't want to clash with @jolly: Please rename it in your next patch update, jolly!

  • Patch Set #8, Line 663: osmo_stream_cli_set_read_cb2(asp->client, xua_cli_read_cb);

    You probably need to do "osmo_stream_cli_set_segmentation_cb(asp->client, NULL);" here too?

    good catch. I didn't think of restart/reconfigure.

  • Patch Set #8, Line 833: }

    so how are we now calling osmo_stream_srv_destroy() once the socket is detected as closed? […]

    I think all the "msgb_length(msg) == 0" cases are just an ugly workaround for code that doesn't register a disconnect_cb.

    So let's do this properly with disconnect_cb, @jolly is working on that AFAICT.

To view, visit change 35070. To unsubscribe, or for help writing mail filters, visit settings.