Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32970 ) Change subject: all models, HR1 codec: select RTP output format via vty option ...................................................................... Patch Set 1: (2 comments) File include/osmo-bts/bts.h: https://gerrit.osmocom.org/c/osmo-bts/+/32970/comment/ba4ccf8d_7c603f95 PS1, Line 303: bool emit_hr_rfc5993; maybe an enum specific type would be better here, but not sure if such an enum exists already. File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32970/comment/c3acefc6_c7a8ce3c PS1, Line 1705: send_rtp_rfc5993(lchan, fn, msg->data, msg->len); since we have a msgb here, it good be far better to msgb_push(1) instead of memcpying the entire payload. (this requires making sure the msgb is allocated with headroom). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I168191874a062429a57904511a1e89e3f588732e Gerrit-Change-Number: 32970 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Wed, 24 May 2023 09:17:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment