Attention is currently required from: falconia.

View Change

2 comments:

• File include/osmo-bts/bts.h:

  • Patch Set #1, Line 303: bool emit_hr_rfc5993;

    maybe an enum specific type would be better here, but not sure if such an enum exists already.

• File src/common/l1sap.c:

  • Patch Set #1, Line 1705: send_rtp_rfc5993(lchan, fn, msg->data, msg->len);

    since we have a msgb here, it good be far better to msgb_push(1) instead of memcpying the entire payload. (this requires making sure the msgb is allocated with headroom).

To view, visit change 32970. To unsubscribe, or for help writing mail filters, visit settings.