Attention is currently required from: jolly, laforge, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 )
Change subject: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages
......................................................................
Patch Set 2:
(1 comment)
File library/GSM_RR_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647/comment/6bbe063b_5f647...
PS2, Line 597: } with { variant "TAG(cksn, tag = 'B'H)" };
No, it's correct. […]
Agree with "PRESENCE". However, I still think this specific variant belongs to line 592, since I see no "tag" nor "cksn" fields in here?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I79ca7ee2b94bb370cd7162cfd9db436049998041
Gerrit-Change-Number: 32647
Gerrit-PatchSet: 2
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly
andreas@eversberg.eu
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 24 May 2023 09:11:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment