Attention is currently required from: laforge, pespin, fixeria, dexter.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ......................................................................
Patch Set 4:
(3 comments)
File src/common/l1sap.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4942): https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/ffeb95cd_aa9062a6 PS4, Line 1267: } else else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4942): https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/58353208_a134f7a7 PS4, Line 1267: } else suspect code indent for conditional statements (16, 20)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-4942): https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/0a32fa84_553c9109 PS4, Line 1268: if (OSMO_UNLIKELY Statements should start on a tabstop