Attention is currently required from: fixeria, pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32181 ) Change subject: tests: Add initial osmo_io tests ...................................................................... Patch Set 13: Code-Review+1 (2 comments) File tests/osmo_io/osmo_io_test.c: https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/46d61c5c_720ce9a2 PS3, Line 54: printf("%s: Write returned rc=%d\n", osmo_iofd_get_name(iofd), rc); yes, passing the msg to the write_cb is the right thing to do. Not sure whether 'const' is a good idea. After all, the call-back could also free a 'const' msgb and it would be just as much as an error. Also, it is perfectly legal for the call-back to modify the msgb at that point (for example to zero some kind of "secret" value (password, crypto key or whatever) which they don't want to retain in memory even of something that's returned to the talloc pool automatically a few nanoseconds later. File tests/osmo_io/osmo_io_test.c: https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/9b2ad388_4f6f3dc8 PS9, Line 95: for (int i = 0; i < 128; i++) Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia67629e53f4d2e5784177250d58e268fdfcaa0c2 Gerrit-Change-Number: 32181 Gerrit-PatchSet: 13 Gerrit-Owner: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 09 May 2023 23:24:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Comment-In-Reply-To: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-MessageType: comment