Attention is currently required from: fixeria, pespin, daniel.

Patch set 13:Code-Review +1

View Change

2 comments:

• File tests/osmo_io/osmo_io_test.c:

  • Patch Set #3, Line 54: printf("%s: Write returned rc=%d\n", osmo_iofd_get_name(iofd), rc);

    Correct. […]

    yes, passing the msg to the write_cb is the right thing to do. Not sure whether 'const' is a good idea. After all, the call-back could also free a 'const' msgb and it would be just as much as an error. Also, it is perfectly legal for the call-back to modify the msgb at that point (for example to zero some kind of "secret" value (password, crypto key or whatever) which they don't want to retain in memory even of something that's returned to the talloc pool automatically a few nanoseconds later.

• File tests/osmo_io/osmo_io_test.c:

  • Patch Set #9, Line 95: for (int i = 0; i < 128; i++)

    I would like to keep those as is tbh. […]

    Ack

To view, visit change 32181. To unsubscribe, or for help writing mail filters, visit settings.