Attention is currently required from: laforge, pespin.
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35901?usp=email )
Change subject: Make PDP-Type and APN from GSUP AuthInfoReq available through all layers
......................................................................
Patch Set 2:
(1 comment)
File src/aaa_diameter_swx.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35901/comment/63d4ef26_7e58…
PS1, Line 192: %16#21 ->
Do you tried to encode the ipv4 with ip_to_bin()? like
we do in src/epdg_gtpc_s2b. […]
Also I think we need to add an additional inherit.
I can't find an avp_name(x, x) type definition for it.
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35901?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I3f29b00f57f433f8623b9f0a5048c83985e5cced
Gerrit-Change-Number: 35901
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Feb 2024 14:05:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment