Change in osmo-ttcn3-hacks[master]: hnbap: Use protocolExtensions := * in tr and omit in ts templates - gerrit-log

24 Aug 2022


      Attention is currently required from: laforge, daniel.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29206 )
Change subject: hnbap: Use protocolExtensions := * in tr and omit in ts templates
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File library/hnbap/HNBAP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29206/comment/9dd07386_e80f8... 
PS2, Line 93: ts_HNBAP_HNBRegisterRequest
Something is wrong here:
* this is a send (ts_) template, so it should be '(value)', not '(present)';
* all arguments should also be '(value)' or '(omit)', not '(present)';
* there should be no '?' nor '*' in send templates.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29206
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic8f9afc9d74507f7d73f52cefc92ed1c2dc4b1bc
Gerrit-Change-Number: 29206
Gerrit-PatchSet: 2
Gerrit-Owner: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Wed, 24 Aug 2022 11:54:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment