Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28161 ) Change subject: pySim-shell: add export option to add CREATE FILE APDUs ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/28161/comment/ff774aab_d60554c4 PS3, Line 556: self._cmd.poutput("apdu 00E00000%02x%s" % (int(len(self._cmd.rs.selected_file_fcp_hex)/2), str(self._cmd.rs.selected_file_fcp_hex))) I would have preferred if we actually generate the 'create file' command here. That would be readable with its arguments. But I understand that you don' have the decoded FCP here and a "raw" statement is more convenient (and less error-prone) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If529b86062f7c678c9c75f46ce9ca116cea8b47b Gerrit-Change-Number: 28161 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 May 2022 19:52:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment