Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28725 ) Change subject: Introduce APDU/TPDU trace decoder ...................................................................... Patch Set 1: (2 comments) File pySim/gsmtap.py: https://gerrit.osmocom.org/c/pysim/+/28725/comment/8960a263_adf7d995 PS1, Line 153: Int8ub One advantage of using Const is that the parser will fail early with a clean error message, and not somewhere in the middle with less obvious reason like ShortRead. The version check below is done after parsing, so it only works if the bytestream was parsed without exceptions. I any case, this is not critical, you can keep this unchanged. File pySim/ts_31_102.py: https://gerrit.osmocom.org/c/pysim/+/28725/comment/5e0495d8_671c6d30 PS1, Line 303: # 3gPP TS 31.102 Section 7.5.2.1 Ah, indeed. Nevermind. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I862d93163d495a294364168f7818641e47b18c0a Gerrit-Change-Number: 28725 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 22 Jul 2022 10:55:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment