Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27129 ) Change subject: ts_102_221: Handle nested security condition data objects ...................................................................... Patch Set 1: Code-Review-1 (4 comments) Patchset: PS1: CR-1 due to non-existing '++' operator. File pySim/ts_102_221.py: https://gerrit.osmocom.org/c/pysim/+/27129/comment/dd3716c5_a707e707 PS1, Line 479: def from_bytes(self, binary:bytes): Missing type hint: -> list https://gerrit.osmocom.org/c/pysim/+/27129/comment/0930b7e7_ca64a633 PS1, Line 486: def to_bytes(self): Missing type hint: -> bytes https://gerrit.osmocom.org/c/pysim/+/27129/comment/acfaf1d3_640866c6 PS1, Line 489: ++ Looks like you meant '+=' here? This could be done simpler: encoded = [self.children.encode(e) for e in self.decoded] return b''.join(encoded) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icb09cf3a90303a86fc77406b8b0806b5c926f1be Gerrit-Change-Number: 27129 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 10 Feb 2022 13:22:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment