Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27129 )

Change subject: ts_102_221: Handle nested security condition data objects ......................................................................

Patch Set 1: Code-Review-1

(4 comments)

Patchset:

PS1: CR-1 due to non-existing '++' operator.

File pySim/ts_102_221.py:

https://gerrit.osmocom.org/c/pysim/+/27129/comment/dd3716c5_a707e707 PS1, Line 479: def from_bytes(self, binary:bytes): Missing type hint:

-> list

https://gerrit.osmocom.org/c/pysim/+/27129/comment/0930b7e7_ca64a633 PS1, Line 486: def to_bytes(self): Missing type hint:

-> bytes

https://gerrit.osmocom.org/c/pysim/+/27129/comment/acfaf1d3_640866c6 PS1, Line 489: ++ Looks like you meant '+=' here? This could be done simpler:

encoded = [self.children.encode(e) for e in self.decoded] return b''.join(encoded)