Attention is currently required from: dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34351?usp=email )

Change subject: mgcp_client_fsm: fix inconsistent API (param_present, param). ......................................................................

Patch Set 3:

(3 comments)

File include/osmocom/mgcp_client/mgcp_client.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/96831704_316cf607 PS2, Line 121: struct mgcp_msg {

I have checked this one. It is not used from outside. […]

Can you point me to the API allocating and returning a pointer to this struct? because I cannot find it.

If you mean this struct is not used at all outside of the lib, then why is it in a public header?

File include/osmocom/mgcp_client/mgcp_client_fsm.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/9d7793ba_2ce016a8 PS2, Line 70: struct mgcp_codec_param2 codecs_param[MGCP_MAX_CODECS];

Yes, that is a real problem ;-/ I will add an alloc function in a different patch.

Ok, better sort that kind of problems *before* this patch.

File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/6a99cd39_9d7ca82f PS2, Line 1376: LOGPMGW(mgcp, LOGL_DEBUG, "using depreacted struct member mgcp_msg->param, please use mgcp_msg->codecs_param!\n");

Done

You marked as DONE but I see no change...