Attention is currently required from: fixeria.
neels has posted comments on this change by neels. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/37993?usp=email )
Change subject: coverity CID#313611
......................................................................
Patch Set 2:
(1 comment)
File src/libosmo-pfcp/pfcp_msg.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/37993/comment/4528239d_d27a5c26… :
PS1, Line 589: struct osmo_fsm_inst *fi = m ? (m->ctx.session_fi ?: m->ctx.peer_fi)
: NULL;
Checking `m` against `NULL` below and returning early
makes these ternary checks redundant. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/37993?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Ic5c87e029fe761b24ef9dcf801376da7b5a8d290
Gerrit-Change-Number: 37993
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Sep 2024 01:56:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>