Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29528 )

Change subject: osmux: Allocate struct osmux_out_handle through API ......................................................................

Patch Set 1:

(1 comment)

File src/osmux_input.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/29528/comment/599b1b13_9a7d24ac PS1, Line 737: /* DEPRECATED: Use talloc_free() instead (will call osmux_xfrm_input_talloc_destructor()) */ What are the benefits of using a talloc destructor? If I allocate something with talloc, then yes, I will most likely deallocate it with talloc_free(). If I allocate something using a dedicated function, then intuitively I will be looking for its deallocation counterpart. IMO, this makes the API inconsistent and less intuitive. I might guess it's needed when you're free()ing the parent context, so that the osmux_in_handle is deallocated properly?