Attention is currently required from: lynxis lazus, pespin.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38356?usp=email )
Change subject: vlr: use correct types for vlr_timer ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/38356/comment/e68eecbd_ccb1a4e5?usp=... : PS1, Line 9: an integer
an integer is signed (can be negative or positive) by definition unlesss explicitly stated, I see no […]
(It's not critical, not blocking), but I was a bit confused reading this before I looked at the actual patch and found out that T was erroneously defined as unsigned. This is why I suggested to stress that it must be signed, since Osmocom specific timers are negative.
-
fixeria